-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(PlaywrightNewScreenshot): added the expectScreenshot fixture #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Playwright Test Component is ready. |
Preview is ready. |
@NasgulNexus There are double dashes in snapshot names |
fixed the double dash |
amje
requested changes
Dec 22, 2023
NasgulNexus
force-pushed
the
playwright-light-dark-theme
branch
from
December 22, 2023 14:18
8d7998b
to
30a1ccb
Compare
amje
approved these changes
Dec 25, 2023
NasgulNexus
force-pushed
the
playwright-light-dark-theme
branch
from
December 25, 2023 14:58
3799a1e
to
96d9475
Compare
korvin89
approved these changes
Dec 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added the expectScreenshot fixture, which makes it possible to take screenshots in light and dark themes